New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DesktopCentral arbitrary file upload exploit. #2650
Add DesktopCentral arbitrary file upload exploit. #2650
Conversation
Processing.... |
Module isn't msftidy compliant, should be before continue:
|
'Thomas Hibbert' # thomas.hibbert@security-assessment.com | ||
], | ||
'License' => MSF_LICENSE, | ||
'References' => |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't there any reference :?
msftidy still complains:
|
require 'msf/core' | ||
|
||
class Metasploit3 < Msf::Exploit::Remote | ||
Rank = ExcellentRanking |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The full module should follow the indentation standard described here: https://github.com/rapid7/metasploit-framework/wiki/Indentation-Standards
The important thing is: "Using two-space soft tabs" which translates as "one indent level == two-space soft tab" :)
I've download the trial but it is build 80294 so the module isn't working because of the patch I guess. Do you know if DesktopCentral keeps a repository of old versions? Otherwise we'll need a pcap of the module working for verification. You can send it to msfdev[at]metasploit.com. Thanks! |
Hi, There's a repository of old versions at GPG ID: 8BB3F67B651E52C81CC4BDEC3CA0319F6E9ECEBA On 21 November 2013 04:21, Juan Vazquez notifications@github.com wrote:
|
cool, thank, you, testing! |
Tested successfully, thanks @pnegry !!! Did some changes and clean up, you can see the final result here: 851cf6f Please feel free to review and don't hesitate to ask if you have question :) Hope it's useful in order to make easier your other pull request :) Test result:
|
No description provided.