Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove @peer for modules that use HttpClient #2718

Merged
merged 2 commits into from Dec 5, 2013

Conversation

wchen-r7
Copy link
Contributor

@wchen-r7 wchen-r7 commented Dec 3, 2013

The HttpClient mixin has a peer() method, therefore these modules should not have to make their own. Also new module writers won't repeat the same old code again.

The HttpClient mixin has a peer() method, therefore these modules
should not have to make their own. Also new module writers won't
repeat the same old code again.
@jvazquez-r7
Copy link
Contributor

Processing....

@jvazquez-r7
Copy link
Contributor

  • Verification steps:
  • travis passes
  • Manual review / inspection
  • msfconsole loads all the modules
  • Modules modified:
modules/auxiliary/admin/http/axigen_file_access.rb
modules/auxiliary/admin/http/iis_auth_bypass.rb
modules/auxiliary/admin/http/intersil_pass_reset.rb
modules/auxiliary/admin/http/mutiny_frontend_read_delete.rb
modules/auxiliary/admin/http/sophos_wpa_traversal.rb
modules/auxiliary/scanner/http/dolibarr_login.rb
modules/auxiliary/scanner/http/hp_sitescope_getfileinternal_fileaccess.rb
modules/auxiliary/scanner/http/hp_sitescope_getsitescopeconfiguration.rb
modules/auxiliary/scanner/http/hp_sitescope_loadfilecontent_fileaccess.rb
modules/auxiliary/scanner/http/vcms_login.rb
modules/exploits/linux/http/astium_sqli_upload.rb
modules/exploits/linux/http/mutiny_frontend_upload.rb
modules/exploits/linux/http/openfiler_networkcard_exec.rb
modules/exploits/linux/http/wanem_exec.rb
modules/exploits/linux/http/zen_load_balancer_exec.rb
modules/exploits/linux/http/zenoss_showdaemonxmlconfig_exec.rb
modules/exploits/multi/http/auxilium_upload_exec.rb
modules/exploits/multi/http/cuteflow_upload_exec.rb
modules/exploits/multi/http/extplorer_upload_exec.rb
modules/exploits/multi/http/glossword_upload_exec.rb
modules/exploits/multi/http/hp_sitescope_uploadfileshandler.rb
modules/exploits/multi/http/kordil_edms_upload_exec.rb
modules/exploits/multi/http/mobilecartly_upload_exec.rb
modules/exploits/multi/http/movabletype_upgrade_exec.rb
modules/exploits/multi/http/php_volunteer_upload_exec.rb
modules/exploits/multi/http/qdpm_upload_exec.rb
modules/exploits/multi/http/sflog_upload_exec.rb
modules/exploits/multi/http/sonicwall_gms_upload.rb
modules/exploits/multi/http/testlink_upload_exec.rb
modules/exploits/multi/http/wikka_spam_exec.rb
modules/exploits/unix/webapp/datalife_preview_exec.rb
modules/exploits/unix/webapp/hastymail_exec.rb
modules/exploits/unix/webapp/invision_pboard_unserialize_exec.rb
modules/exploits/unix/webapp/kimai_sqli.rb
modules/exploits/unix/webapp/php_charts_exec.rb
modules/exploits/unix/webapp/projectpier_upload_exec.rb
modules/exploits/unix/webapp/sugarcrm_unserialize_exec.rb
modules/exploits/unix/webapp/tikiwiki_unserialize_exec.rb
modules/exploits/unix/webapp/zoneminder_packagecontrol_exec.rb
modules/exploits/windows/http/avaya_ccr_imageupload_exec.rb
modules/exploits/windows/http/hp_imc_mibfileupload.rb
modules/exploits/windows/http/hp_sitescope_runomagentcommand.rb
modules/exploits/windows/http/sap_host_control_cmd_exec.rb
modules/exploits/windows/http/umbraco_upload_aspx.rb
modules/exploits/windows/http/vmware_vcenter_chargeback_upload.rb
modules/exploits/windows/misc/ibm_director_cim_dllinject.rb
  • All of them include the HttpClient, tested with a code like this one, test_files.txt including the modified files:
f = File.new("test_files.txt", "rb")
f.each_line { |l|
    system("grep HttpClient #{l}")
}
f.close

Landing!

@jvazquez-r7 jvazquez-r7 merged commit bf34892 into rapid7:master Dec 5, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants