Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolved some msftidy warnings (Set-Cookie) #3354

Merged
merged 1 commit into from May 12, 2014

Conversation

firefart
Copy link
Contributor

Title says it all.

BTW: The cisco_ironport_enum module never worked correctly because of single apostrophes:

'cookie'       => '#{cookie}'

I will have a look if we can check this.

@wvu
Copy link
Contributor

wvu commented May 12, 2014

Thanks!

@wvu wvu self-assigned this May 12, 2014
@@ -80,7 +80,7 @@ def is_app_asdm?

if res &&
res.code == 200 &&
res.headers['Set-Cookie'].match(/webvpn/)
res.get_cookies.include?('webvpn')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch with the include?.

wvu added a commit to wvu/metasploit-framework that referenced this pull request May 12, 2014
@wvu wvu merged commit 3f3283b into rapid7:master May 12, 2014
@firefart firefart deleted the msftidy_cookie branch May 12, 2014 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants