New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Http print standardization #343
Conversation
Allows print_* overrides to show it when it's available.
Fixes breakage with modules that use print_line() or similar. This commit also includes some RDoc additions and markup fixes
This is now handled by the HttpServer mixin
Conflicts: modules/exploits/windows/browser/apple_quicktime_marshaled_punk.rb modules/exploits/windows/browser/apple_quicktime_rtsp.rb modules/exploits/windows/browser/apple_quicktime_smil_debug.rb
Looking into it right now. |
So it looks like if a browser module prints a message like this: The IP:Port will get printed twice. Only one module does this in windows/browsers, and that's fixed in my local branch. Will commit it. |
Another scenario that can result the ip:port being printed twice: Which will have the following output: A lot of modules do this. Here are the ones I found under windows/browser: |
I agree with @wchen-r7 -- in order to land this, either the mixin's print_status will have to handle the case where the module's print_status is trying to already print rhost:rport, or all the modules will have to be updated. (It'd be nice to see the latter so future copy-pasters won't screw themselves up) |
Talked to egypt. So we've concluded it's probably best to hold on to this pull request until the release. |
This implements output standardization for browser exploits via the HttpServer mixin. Format is similar to what was being done manually before but is easier to use (just normal
print_status
usage) and makes module code easier to read.Example output: