Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smb datastore fixes #3631

Merged
merged 4 commits into from Aug 12, 2014
Merged

Smb datastore fixes #3631

merged 4 commits into from Aug 12, 2014

Conversation

wchen-r7
Copy link
Contributor

@wchen-r7 wchen-r7 commented Aug 7, 2014

This patch should safely modify rport and smbdirect without writing to their datastore options. Same type of fix as #3630. If you guys feel this kind of fix is ok to correct direct datastore assignments, my next patch will attempt to fix them all instead of having a bunch of PRs.

@wchen-r7 wchen-r7 added the module label Aug 7, 2014
@jhart-r7
Copy link
Contributor

jhart-r7 commented Aug 9, 2014

I think what you are doing is OK. While modifying datastore is a convenient way to pass stuff around, it is a hack. datastore (IMO) should be used to store just what the user set and and it shouldn't change at runtime.

@jvazquez-r7
Copy link
Contributor

Test successful:

msf auxiliary(smb_enumusers_domain) > run

Login Failed: The SMB server did not reply to our request
[*] 172.16.158.227 : WORKGROUP\JUAN-6ED9DB6CA8$, JUAN-6ED9DB6CA8\Administrator
[*] Scanned 1 of 1 hosts (100% complete)
[*] Auxiliary module execution completed
msf auxiliary(smb_version) > run

[*] 172.16.158.227:445 is running Windows 2003 Service Pack 2 (language: Unknown) (name:JUAN-6ED9DB6CA8) (domain:WORKGROUP)
[*] Scanned 1 of 1 hosts (100% complete)
[*] Auxiliary module execution completed
msf auxiliary(smb_lookupsid) > run

[*] 172.16.158.227 PIPE(LSARPC) LOCAL(JUAN-6ED9DB6CA8 - 5-21-1053798420-2132824579-2427655443) DOMAIN(WORKGROUP - )
[*] 172.16.158.227 USER=Administrator RID=500
[*] 172.16.158.227 USER=Guest RID=501
[*] 172.16.158.227 GROUP=None RID=513
[*] 172.16.158.227 TYPE=4 NAME=HelpServicesGroup rid=1000
[*] 172.16.158.227 USER=SUPPORT_388945a0 RID=1001
[*] 172.16.158.227 TYPE=4 NAME=TelnetClients rid=1002
[*] 172.16.158.227 USER=ASPNET RID=1003
[*] 172.16.158.227 JUAN-6ED9DB6CA8 [Administrator, Guest, SUPPORT_388945a0, ASPNET ]
[*] Scanned 1 of 1 hosts (100% complete)
[*] Auxiliary module execution completed
msf auxiliary(smb_lookupsid) >

Landing!

@jvazquez-r7 jvazquez-r7 merged commit 3b27102 into rapid7:master Aug 12, 2014
jvazquez-r7 added a commit that referenced this pull request Aug 12, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants