Add variable HTTP header for apache_mod_cgi_bash_env #3902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also switch from OptEnum to OptString for flexibility.
wvu
force-pushed
the
feature/bash_env
branch
from
05a8ace
to
044eeb8
Compare
hdm
pushed a commit
to hdm/metasploit-framework
that referenced
this pull request
Sep 27, 2014
| @@ -38,8 +38,8 @@ def initialize(info = {}) | |||
|
|
|||
| register_options([ | |||
| OptString.new('TARGETURI', [true, 'Path to CGI script']), | |||
| OptEnum.new('METHOD', [true, 'HTTP method to use', 'GET', | |||
| ['GET', 'POST']]), | |||
| OptString.new('METHOD', [true, 'HTTP method to use', 'GET']), | |||
There was a problem hiding this comment.
OptEnum is a better choice than OptString for this. Why change the type?
There was a problem hiding this comment.
There may be cases where a non-standard method is useful?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also switch from OptEnum to OptString for flexibility.
cc @jvazquez-r7