Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup modules #4011

Merged
merged 3 commits into from Oct 14, 2014
Merged

Fixup modules #4011

merged 3 commits into from Oct 14, 2014

Conversation

todb-r7
Copy link

@todb-r7 todb-r7 commented Oct 14, 2014

A few minor fixes to modules. This kind of PR traditionally used to happen once a week -- I'm trying to up the frequency of these edits to once a day, so that we don't spend several days with imperfect grammar for Framework folks.

/cc @shuckins-r7 @cdoughty-r7 -- if you want something more or less frequent, let me know.

/cc @rapid7/framework-public-committers and @rapid7/framework-rapid7-committers -- please double check your titles and descriptions prior to landing. While you might be super excited to get a shell after troubleshooting and testing, the titles and descriptions are about the most visible parts of modules that most normal people see.

Also, modules often show up on other sites (packetstorm, osvdb, bugtraq) when things are landed, or even when things are being PR'ed; AFAIK, these third-party indexers of our material don't wait for Metasploit Pro releases, and they don't tend to update to fix spelling errors. :)

Pre-emptively assigning to @wvu-r7 since he tends to land these things with aplumb and gusto.

Tod Beardsley added 3 commits October 14, 2014 11:58
People often like to supress failed attempts. Note that this change may
or may not have any effect, given the status of rapid7#3995.

This module was introduced in PR rapid7#3947.
@espreto
Copy link
Contributor

espreto commented Oct 14, 2014

@todb-r7 Thanks for the tip. The next modules will have better descriptions. :)

wvu added a commit to wvu/metasploit-framework that referenced this pull request Oct 14, 2014
@wvu wvu merged commit 56534e7 into rapid7:master Oct 14, 2014
@jhart-r7
Copy link
Contributor

Ironically, this PR corrected the English/Grammar in hp_enum_perfd, but now the description is incorrect -- this module enumerates more than just the process list.

@todb
Copy link
Contributor

todb commented Oct 18, 2014

Better description? I tried to grasp what was going on from the screenshots and glancing at the run() bits but pslisting is about all I could tease out.

The original description about "enumerating the environment" was pretty vague, and didn't cover barometric pressure or wetland erosion or anything.

On October 17, 2014 6:31:30 PM CDT, Jon Hart notifications@github.com wrote:

Ironically, this PR corrected the English/Grammar in
hp_enum_perfd, but now the description is incorrect -- this
module enumerates more than just the process list.


Reply to this email directly or view it on GitHub:
#4011 (comment)

Sent from a tiny computer.
Text (insecure): 512-438-9165

@kernelsmith
Copy link
Contributor

LOL @todb-r7

On Oct 17, 2014, at 19:04, Tod Beardsley notifications@github.com wrote:

Better description? I tried to grasp what was going on from the screenshots and glancing at the run() bits but pslisting is about all I could tease out.

The original description about "enumerating the environment" was pretty vague, and didn't cover barometric pressure or wetland erosion or anything.

On October 17, 2014 6:31:30 PM CDT, Jon Hart notifications@github.com wrote:

Ironically, this PR corrected the English/Grammar in
hp_enum_perfd, but now the description is incorrect -- this
module enumerates more than just the process list.


Reply to this email directly or view it on GitHub:
#4011 (comment)

Sent from a tiny computer.
Text (insecure): 512-438-9165

Reply to this email directly or view it on GitHub.

@todb-r7 todb-r7 deleted the fixup-modules branch November 25, 2014 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants