Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support SRVHOST option for exploits/windows/browser/msvidctl_mpeg2.rb #4148

Merged
merged 3 commits into from Nov 7, 2014

Conversation

wchen-r7
Copy link
Contributor

@wchen-r7 wchen-r7 commented Nov 6, 2014

For #4133

To verify this, this is what I did:

  • Put a print_debug(host.inspect) at line 198
  • Run the module
  • In another terminal, curl -v the exploit's uri
  • curl -v will tell you where you should redirect to. Just follow that and curl again.
  • The print_debug should trigger and print either SRVHOST or Rex::Socket.source_address depending on how you set it. If you change SRVHOST to something else other than 0.0.0.0, then the module will use that. Otherwise it will fall back to Rex::Socket.source_address.
  • When you're done testing, make sure you undo the code change before landing.

Should be srvhost, not lhost
@jhart-r7 jhart-r7 self-assigned this Nov 7, 2014
@jhart-r7 jhart-r7 merged commit 0dbfecb into rapid7:master Nov 7, 2014
jhart-r7 added a commit that referenced this pull request Nov 7, 2014
@jhart-r7
Copy link
Contributor

jhart-r7 commented Nov 7, 2014

Configured eth0:0 as 10.0.1.200 (eth0 is 10.0.1.18).

Set SRVHOST to 0.0.0.0 (the default). Before fix: http://10.0.1.18:8080. After fix: http://10.0.1.18:8080

Set SRVHOST to 10.0.1.200. Before fix: http://10.0.1.18:8080 (incorrect). After fix: http://10.0.1.200:8080 (correct)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants