Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #4293 - Use OperatingSystems::Match::WINDOWS #4297

Merged
merged 1 commit into from Dec 13, 2014

Conversation

wchen-r7
Copy link
Contributor

@wchen-r7 wchen-r7 commented Dec 2, 2014

Fix #4293. Modules should use OperatingSystems::Match::WINDOWS instead of Msf::OperatingSystems::WINDOWS, because the second won't match anything anymore.

To verify:

All the modules can be verified the same way. I'm just gonna use advantech_webaccess_dvs_getcolor as an example:

  • Set up a Windows box. In my test, I used a Windows 7.
  • Start msfconsole
  • Do: use exploit/windows/browser/advantech_webaccess_dvs_getcolor
  • Run the module
  • When your IE browser visits the malicious link, you should not see "os_name" being an unmet requirement.

Fix rapid7#4293. Modules should use OperatingSystems::Match::WINDOWS
instead of Msf::OperatingSystems::WINDOWS, because the second
won't match anything anymore.
@jvazquez-r7
Copy link
Contributor

msf exploit(advantech_webaccess_dvs_getcolor) > [*] Using URL: http://0.0.0.0:8080/N3ICDxb
[*]  Local IP: http://192.168.0.3:8080/N3ICDxb
[*] Server started.
[*] 192.168.0.3      advantech_webaccess_dvs_getcolor - Gathering target information.
[*] 192.168.0.3      advantech_webaccess_dvs_getcolor - Sending response HTML.
[!] 192.168.0.3      advantech_webaccess_dvs_getcolor - Exploit requirement(s) not met: activex. For more info: http://r-7.co/PVbcgx

The active doesn't meet but it is expected! Landing!

@jvazquez-r7 jvazquez-r7 merged commit a631ee6 into rapid7:master Dec 13, 2014
jvazquez-r7 added a commit that referenced this pull request Dec 13, 2014
* instead of Msf::OperatingSystems::WINDOWS
@wchen-r7 wchen-r7 deleted the issue_4293 branch August 22, 2016 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BES-based modules should use OperatingSystems::Match::WINDOWS instead of Msf::OperatingSystems::WINDOWS
2 participants