New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposed fix for #4305 #4317
Merged
Merged
Proposed fix for #4305 #4317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename UDP_SECRET to just SECRET, as it is used for more than just UDP Rename and properly document GATEWAY option Introduce an option to configure what UDP port will be probed
Oops:
One sec @jhart-r7 |
Hmm that's no bueno:
Wonder what's wrong with SECRET... |
ah you got it @jhart-r7 |
Looks good, verified with tcpdump command |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of sending a probe to a random host in 177/8 to attempt to see what the source and destination MACs are (and, in turn, what the Capture module should use when using
capture_sendto
), this PR makes this process send a random UDP probe to www.metasploit.com but with a TTL of 1, thereby ensuring that it shouldn't make it past the first hop, if at all. It also makes the probe host and port configurable, and cleans up the "secret".Note that this is a diff against master but has the fix for #4306 from #4311 merged in. Once #4311 is landed this should update.
Defect and Fix Validation
Note that these steps can be used to both confirm that the defect is fixed but also to demonstrate the defect in the first place by running against a parent revision:
use exploits/multi/ids/snort_dce_rpc
, set anRHOST
for a live host in the same broadcast domain. Run. Confirm that no UDP traffic is sent to 177/8 and that the only traffic caused by this module is an ARP lookup for the RHOST followed by a single 139/TCP packet, and that the source MAC is from the system running msf and that the destination MAC is RHOST's., set an
RHOST`` for a live host NOT in the same broadcast domain. Run. Confirm that no UDP traffic is sent to 177/8. Confirm that a random UDP datagram is sent to www.metasploit.com with a TTL of 1, and that the source MAC is from the system running msf and that the destination MAC is the default gateway's.INTERFACE
on a system with multiple interfaces. Overkill?