Fix #4323 - More undef 'payload_exe' in other modules #4324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Root cause: payload_exe is an accessor in the TFPT command stager mixin, you need stager_instance in order to retreive that info.
Fix rapid7#4246 ... so it will automatically close the ticket.
wchen-r7
changed the title
| @@ -163,7 +163,7 @@ def exploit | |||
| end | |||
|
|
|||
| def on_new_session(client) | |||
| return if not payload_exe | |||
| return if not stager_instance.payload_exe | |||
There was a problem hiding this comment.
some day, these should be unless instead of if not. but that day is not today.
|
Hmm I'm going to have to reopen #4246 after this lands. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Root cause
payload_exe is an accessor in the TFPT command stager mixin, you need stager_instance in order to retrieve that info.
This fixes #4323