Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enum_ad_* post module fixes #4389

Merged
merged 4 commits into from
Dec 15, 2014
Merged

enum_ad_* post module fixes #4389

merged 4 commits into from
Dec 15, 2014

Conversation

Meatballs1
Copy link
Contributor

#3175 broke enum_ad_* post modules as it changed the return type from the ADSI queries.

Fixes: #4387

Poke @OJ @bcook-r7

This also modifies the legacy Railgun LDAP implementation so it returns data in the same format.

Verification

  • Run enum_ad_computers - results should be hashes :(
  • Apply PR
  • enum_ad_computers, enum_ad_user_comments, enum_ad_service_principal_names and enum_ad_to_wordlist - results should be as expected

@jhart-r7
Copy link
Contributor

It may be worth starting to add some unit tests to spec/lib/msf/core/post/windows/ldap.rb

@Meatballs1
Copy link
Contributor Author

Would be painful as all the data is pretty much from an active session. If someone wants to mock railgun/extapi...

@bcook-r7
Copy link
Contributor

Thanks a lot, taking a look now. Mocking extapi sounds like 'ecstasy' according to my spell checker.

@bcook-r7 bcook-r7 merged commit e914061 into rapid7:master Dec 15, 2014
bcook-r7 pushed a commit that referenced this pull request Dec 15, 2014
Fixes #4387 by adjusting for the new return type from ADSI queries.
@Meatballs1 Meatballs1 deleted the adsi_fixes branch December 15, 2014 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

#3175 broke enum_ad*
3 participants