Remove references to Redmine in code #4439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 19, 2014 17:27
See rapid7#4400. This should be all of them, except for, of course, the module that targets Redmine itself. Note that this also updates the README.md with more current information as well.
|
This may in fact fix #4400. |
| @@ -532,10 +532,8 @@ def check_lines | |||
| error("Writes to stdout", idx) | |||
| end | |||
|
|
|||
| # You should not change datastore in code. For reasons. See | |||
|
Reviewed. Looks good. |
wvu
added a commit
to wvu/metasploit-framework
that referenced
this pull request
Dec 20, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #4400. This should be all of them, except for, of course, the module that targets Redmine itself.
Note that this also updates the README.md with more current information as well.
We should not expect our Redmine instance to be up for much longer. If the bugs that say "See Remdine issue 1234" are not actually resolved yet, my guess is that those issues should be recreated on GitHub. However, if they haven't the bugs described are either resolved, or haven't been important enough to survive triage.