New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change HTTP requests to succeed when going through HTTP proxies #4708
Conversation
Makes sense to me. Test after changes:
Thanks @firefart and @julianvilas ! |
woohoo thx! |
'uri' => uri, | ||
'encode_params' => false, | ||
'vars_get' => { | ||
cmd => "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be cmd => cmd
?
Or drop the cmd
argument from the function?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it shoudl result it /uri?my_command_to_execute so I think the syntax is correct, we don't need a value here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So then cmd
is redundant and should be removed for clarity?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah no I see that does make sense, its just not very clear :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
jeah it's tricky to read
As @firefart said in #3314 (comment) (thanks buddy!), the way the payload is sent to the server in the HTTP request must be inside
vars_get
and not directly asuri
to avoid problems when Reverse HTTP proxies are in use.The changes in this PR are to make it happen :)
Testing env:
Test without apache proxy:
Test with apache mod_proxy_ajp:
Apache logs: