Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop ungenuine x64 support in ms13_022_silverlight_script_object #4798

Merged
merged 1 commit into from Feb 21, 2015

Conversation

wchen-r7
Copy link
Contributor

The MS13-022 exploit does not actually run as x64. IE by default still runs 32-bit so BES will always automatically select that target.

If IE forces x64 (which can be done manually), the BES detection code will see it as ARCH_X86_64, and the payload generator will still end up generating a x86 payload anyway.

If the user actually chooses a x64 payload, such as windows/x64/meterpreter/reverse_tcp, the exploit is going to crash because you can't run x64 shellcode in a 32-bit payload or process.

I pointed out this issue yesterday with @jvazquez-r7, plus he worked on this module, so I'd like to assign this PR to him to verify.

Test

The MS13-022 exploit does not actually run as x64. IE by default
still runs x86 so BES will always automatically select that target.

If IE forces x64 (which can be done manually), the BES detection
code will see it as ARCH_X86_64, and the payload generator will
still end up generating a x86 payload anyway.

If the user actually chooses a x64 payload, such as
windows/x64/meterpreter/reverse_tcp, the exploit is going to crash
because you can't run x64 shellcode on an x86 architecture.
@jvazquez-r7
Copy link
Contributor

Testing was done with the 32bits version indeed: #2677

I'm going to just code review to ensure nothing is forgotten, be confident about my code review skills and land :) (also helps the fact I'm confident about @wchen-r7 explanation and code :P

@jvazquez-r7 jvazquez-r7 merged commit 036a608 into rapid7:master Feb 21, 2015
jvazquez-r7 added a commit that referenced this pull request Feb 21, 2015
…ht_script_object

* Ungenuine support, well deleted
@jvazquez-r7
Copy link
Contributor

Just moved the Arch out of the target, because now there is just one target: ef99022

landed, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants