Fix persistence module to use correct Windows path #4903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the write_script_to_target function, which screws up the path that is used for startup. Currently an escaped path "C://Users//..." is being used instead of using windows standards "C:\Users\...".
todb-r7
changed the title
|
Hello @Jervelund. I am not sure how this patch fixes the problem. The cleanup script needs to use unix-style paths to work with meterpreter, this change doesn't seem to modify what paths end up in the cleanup script (these would still be 'C://Users' and should probably be 'C:/Users' instead). Can you double check this? |
|
I haven't checked that the cleanup script is working, only verified that the path reference in HKLM...\run is now correct. If I understand correctly, this commit only changes the return value of write_script_to_target, which is used for registry startup - the cleanup script should still be the same. |
|
I understand now, thanks! |
hdm
pushed a commit
that referenced
this pull request
Mar 12, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug in the write_script_to_target function, which alters the path that is returned and used for startup.
Currently an escaped path "C://Users//..." is being used instead of using windows standards "C:\Users...".
Issue introduced by #2395