Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix all duplicated keys in modules #4929

Merged
merged 1 commit into from Mar 16, 2015
Merged

Conversation

disenchant
Copy link
Contributor

I recognised, that some modules have duplicated keys. This PR removes the first occurrence of each duplicated key as the second occurrence of it will overwrite the first one anyway. In newer versions of Ruby (e.g. 2.2.0p0) this will generate warnings:

./metasploit-framework/modules/auxiliary/scanner/http/bmc_trackit_passwd_reset.rb:134: warning: duplicated key at line 135 ignored: "SelectedQuestion"
./metasploit-framework/modules/auxiliary/scanner/http/bmc_trackit_passwd_reset.rb:136: warning: duplicated key at line 137 ignored: "answer"
./metasploit-framework/modules/auxiliary/scanner/http/bmc_trackit_passwd_reset.rb:138: warning: duplicated key at line 139 ignored: "confirmanswer"
./metasploit-framework/modules/exploits/linux/http/netgear_dgn2200b_pppoe_exec.rb:188: warning: duplicated key at line 192 ignored: "opendns_parental_ctrl"
./metasploit-framework/modules/post/windows/gather/credentials/razorsql.rb:130: warning: duplicated key at line 131 ignored: "N"

@wvu
Copy link
Contributor

wvu commented Mar 14, 2015

Thanks for getting these done. This would have been the second and final pass (#4832) for #4818.

@wvu wvu self-assigned this Mar 14, 2015
@wvu wvu merged commit 4d3a1a2 into rapid7:master Mar 16, 2015
wvu added a commit that referenced this pull request Mar 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants