fix missing exception handling #5019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a few of our http login scanners needed to handle a couple of other exception classes for when network communication errors occur MSP-12389
thelightcosine
added
bug
jira
|
D'oh ! |
accidentally dropped Errno::ETIMEDOUT from the exception handling MSP-12389
|
Could these be declared as some kind of constant or summat? :D |
|
IMO, |
|
Most of them are rolled up into a Rex exception as well (like ConnectionError). Maybe updating the rollup classes and exception handling would be better? |
|
Landing this now so it can hit the next release cut. No verification steps makes me sad, but now that it's merely adding some extra classes to the rescue, I'm not worried about it. |
todb-r7
pushed a commit
that referenced
this pull request
Mar 30, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a few of our http login scanners needed to handle a couple of other exception classes for when network communication errors occur.
There's not really a lot of manual verification that can happen here as it is highly situational.
MSP-12389