New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Yard doc corrections #5059
Yard doc corrections #5059
Conversation
There's a lot of potential for bikeshedding here, but I'm going to weigh in with my favorite color: I prefer the param name in front of the type, e.g. |
@@ -22,7 +22,7 @@ module Database | |||
# | |||
# @param options [Hash{Symbol=>String}] | |||
# @option options [String] :path Path to use instead of first element of {configurations_pathnames} | |||
# @return [Pathname] if configuration pathname exists. | |||
# @return [String] pathname if configuration pathname exists. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is incorrect. The method returns a Pathname
object.
@jlee-r7 Thanks a lot for your input. This is the first time I am working with YARD docs so please bear with me. Will get it done. |
Awesome, thank you! Documentation isn't an area lots of people are interested in, so I really appreciate any help we can get there. |
Big plus one from me. Much love to anyone who puts time and effort into the
documentation. Kudos for the effort.
|
@jlee-r7 The auxiliary folder is completed now. I hope the large number of files won't be an issue. Some other observations: modules/axiliary/scanner/udp_scanner_template should be moved to documentation since it is just a template file the purpose of which I believe is to provide a boiler template to be implemented by UDP scanner modules. auxiliary/vsploit/exploit/ is empty. It should be removed. |
* Thanks @void-in * See rapid7#5059
The YARD doc comments in the modules have lots of issues that needs to be sorted out. This is the initial pass through. Primarily two types of comments are there:
# @param [Type] name desc
and
# @param name [Type] desc
I opted for the first one since that is the recommended one. If everyone agrees, then will change and make rest of the comments compatible as well.