Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yard doc corrections #5059

Merged
merged 6 commits into from Apr 3, 2015
Merged

Yard doc corrections #5059

merged 6 commits into from Apr 3, 2015

Conversation

void-in
Copy link
Contributor

@void-in void-in commented Apr 2, 2015

The YARD doc comments in the modules have lots of issues that needs to be sorted out. This is the initial pass through. Primarily two types of comments are there:

# @param [Type] name desc

and

# @param name [Type] desc

I opted for the first one since that is the recommended one. If everyone agrees, then will change and make rest of the comments compatible as well.

@jlee-r7
Copy link
Contributor

jlee-r7 commented Apr 2, 2015

There's a lot of potential for bikeshedding here, but I'm going to weigh in with my favorite color: I prefer the param name in front of the type, e.g. @param foo [String] used for thing

@@ -22,7 +22,7 @@ module Database
#
# @param options [Hash{Symbol=>String}]
# @option options [String] :path Path to use instead of first element of {configurations_pathnames}
# @return [Pathname] if configuration pathname exists.
# @return [String] pathname if configuration pathname exists.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is incorrect. The method returns a Pathname object.

@void-in
Copy link
Contributor Author

void-in commented Apr 2, 2015

@jlee-r7 Thanks a lot for your input. This is the first time I am working with YARD docs so please bear with me. Will get it done.

@jlee-r7
Copy link
Contributor

jlee-r7 commented Apr 2, 2015

Awesome, thank you! Documentation isn't an area lots of people are interested in, so I really appreciate any help we can get there.

@OJ
Copy link
Contributor

OJ commented Apr 2, 2015 via email

@void-in
Copy link
Contributor Author

void-in commented Apr 3, 2015

@jlee-r7 The auxiliary folder is completed now. I hope the large number of files won't be an issue.

Some other observations:
modules/axiliary/scanner/modbusclient.rb should be modules/axiliary/scanner/modbus_client.rb
modules/axiliary/scanner/modbusdetect.rb should be modules/axiliary/scanner/modbus_detect.rb
modules/axiliary/scanner/snmp_enumshares.rb should be modules/axiliary/scanner/snmp_enum_shares.rb
modules/axiliary/scanner/snmp_enumusers.rb should be modules/axiliary/scanner/snmp_enum_users.rb
modules/axiliary/scanner/ssh/ssh_enumusers.rb should be modules/axiliary/scanner/ssh/ssh_enum_users.rb

modules/axiliary/scanner/udp_scanner_template should be moved to documentation since it is just a template file the purpose of which I believe is to provide a boiler template to be implemented by UDP scanner modules.

auxiliary/vsploit/exploit/ is empty. It should be removed.

@jvazquez-r7 jvazquez-r7 self-assigned this Apr 3, 2015
jvazquez-r7 added a commit to jvazquez-r7/metasploit-framework that referenced this pull request Apr 3, 2015
@jvazquez-r7 jvazquez-r7 merged commit 452ebcf into rapid7:master Apr 3, 2015
jvazquez-r7 added a commit that referenced this pull request Apr 3, 2015
@jvazquez-r7
Copy link
Contributor

Thanks @void-in eyeballed, fixed a couple of things and landed: 6c36a82

Super thanks of the effort!

Also, moved some cleanup to #5002 to avoid conflicts on that PR :)

@void-in void-in deleted the yard-doc branch April 13, 2015 04:50
@void-in void-in mentioned this pull request Apr 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants