Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconstancy - If datastore['VERBOSE'] vs vprint #5556

Merged
merged 1 commit into from Jun 19, 2015

Conversation

g0tmi1k
Copy link
Contributor

@g0tmi1k g0tmi1k commented Jun 18, 2015

@void-in pointed out in #5554 (#5554 (comment))
vprint_status rather than print_status("...") if datastore['VERBOSE']

The one with the most mistakes in was my own #5530 (fixing my mistake!).

....lazy bash fu

root@kali ~/metasploit-framework$ grep -Ri "VERBOSE"  | grep -i " print_"

@wvu wvu self-assigned this Jun 18, 2015
@@ -102,7 +102,7 @@ def check
return Exploit::CheckCode::Appears if res.body =~ /SVNTag=JBoss_4_/
return Exploit::CheckCode::Appears if res.body =~ /SVNTag=JBoss_5_/

if res.body =~ /ServletException/ # Simple check, if we caused an exception.
if res.body =~ /ServletException/ # Simple check, if we caused an exception.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra space? Doesn't align with anything.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would of been an auto tab replacement (didn't mean for it to happen - didn't know it did)....
As far as I can see, should align with anything anyway?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like three spaces and not a hard tab?

@wvu wvu merged commit ce9481d into rapid7:master Jun 19, 2015
wvu added a commit that referenced this pull request Jun 19, 2015
@wvu
Copy link
Contributor

wvu commented Jun 19, 2015

b994801

@wvu
Copy link
Contributor

wvu commented Jun 19, 2015

FYI: #5554 (comment).

@g0tmi1k g0tmi1k deleted the misc/verbose branch June 21, 2015 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants