Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change ExcellentRanking to GoodRanking for MS14-064 #5560

Merged
merged 1 commit into from Jun 19, 2015

Conversation

wchen-r7
Copy link
Contributor

The ms14_064_ole_code_execution exploit's ranking is being lowered to GoodRanking because of these two reasons:

  1. The vulnerable component isn't in Internet Explorer. And BES can't check it so the exploit still fires even if the target is patched. This is not the desired behavior.
  2. Although rare, we've seen the exploit crashing IE, and since this is a memory curruption type of bug, it should not be in Excellent ranking anyway.

cc @void-in

The ms14_064_ole_code_execution exploit's ranking is being lowered
to GoodRanking because of these two reasons:

1. The vulnerable component isn't in Internet Explorer. And BES can't
   check it so the exploit still fires even if the target is patched.
2. Although rare, we've seen the exploit crashing IE, and since this
   is a memory curruption type of bug, it should not be in Excellent
   ranking anyway.
@void-in
Copy link
Contributor

void-in commented Jun 19, 2015

@wchen-r7 Agree with what you are saying. But just want to point out that at excellent ranking it had an advantage that it was the first exploit used by BAP. And the fact that it could exploit IE4-IE11 was great. Not sure we have another browser exploit for that much wide ranch of IE versions. Anyway, your argument is completely valid. Memory corruption exploits should never be ranked excellent.

@wchen-r7
Copy link
Contributor Author

@void-in I think even if it's GoodRanking, by default it will probably be tried first anyway against IE assuming you don't have Flash installed. Because all the exploits arranged before that are either Flash or Firefox, one or two Android.

@wchen-r7
Copy link
Contributor Author

Also, one day, we'll figure out how to automatically bump or lower ranks at runtime. That way if an exploit has been reliable during a test, it should always be tried first. However this is way beyond the scope of the PR (obviously), also last time we checked this is technically not possible w/ Framework :-(

^ That's @jvazquez-r7's brilliant idea btw.

@void-in
Copy link
Contributor

void-in commented Jun 19, 2015

@wchen-r7 Verified now. The BAP delivers ms14_064_ole_code_execution first even with GoodRanking. Also, the os.js patch works flawlessly now.

@jvazquez-r7
Copy link
Contributor

Thanks @void-in for testing, landing!

@jvazquez-r7 jvazquez-r7 self-assigned this Jun 19, 2015
@jvazquez-r7 jvazquez-r7 merged commit 13a3f27 into rapid7:master Jun 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants