Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review of pull request #559 #563

Merged
merged 8 commits into from Jul 4, 2012
Merged

Review of pull request #559 #563

merged 8 commits into from Jul 4, 2012

Conversation

jvazquez-r7
Copy link
Contributor

This pull request includes a reviewed version of pull request #559. But it isn't still ready:

  • Poison Ivy doesn't run with DEP enabled. Seems due to unpacking. Unpacked PI runs well on DEP.
  • If unpacked IP is run, meterpreter payload doesn't work (tested successfully with windows/exec)

@badishi
Copy link

badishi commented Jul 4, 2012

Maybe integrate the last check I sent with this one? Now that we have the option to send random bytes, the new check I sent instructs the user what to do.

@jvazquez-r7
Copy link
Contributor Author

About the check:

            if response[0, 16] == sig
                print_status("Password appears to be \"admin\".")

This says the password appears to be admin in cases when I've changed it. Because of this Im not very confident with this check :\ Does it work always for you?

@badishi
Copy link

badishi commented Jul 4, 2012

Yep. It should, as the password is the encryption key, and the sig is the encryption of the zeros that we send. What's the pass that gave you a false positive?

@jvazquez-r7
Copy link
Contributor Author

badishi, you're right :) Maybe I didn't reload exploit when checking :_( Sorry for annoying. Check function updated :)

@jvazquez-r7 jvazquez-r7 merged commit ff4a0bc into rapid7:master Jul 4, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants