Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if the payload has a include_send_uuid method before calling it #6051

Merged
merged 1 commit into from Oct 5, 2015

Conversation

bcook-r7
Copy link
Contributor

@bcook-r7 bcook-r7 commented Oct 5, 2015

Otherwise we get an undefined method exception and the payload fails to stage.
Fixes #6040

This is sort-of nasty because it appears that we silently rescue exceptions thrown during staging, which makes this look like the stager hung (and the payload crashes) rather than a simpler-to-fix check for a method existence.

@OJ may want to refactor things so we do not need this, but this should stop the bleeding for now.

Verification steps

  • Generate a 64-bit and 32-bit linux reverse TCP shell payload
  • Stage it and ensure that you get a shell.

Otherwise we get an undefined method exception and the payload fails to stage.
Fixes rapid7#6040
@wvu wvu self-assigned this Oct 5, 2015
@OJ
Copy link
Contributor

OJ commented Oct 5, 2015

Thanks Brent. I've got something very similar in a branch I am going to push today. I land this as well, given that it's part of my PR, and that gets us over the initial problem. My stuff will clean things up a little, I'd appreciate your keen eye once that comes in!

Cheers

@wvu wvu assigned OJ and unassigned wvu Oct 5, 2015
@OJ
Copy link
Contributor

OJ commented Oct 5, 2015

Ah! I see @wvu-r7 has taken it. I shall leave it to him and finish off the other stuff.

@wvu wvu assigned wvu and unassigned OJ Oct 5, 2015
@wvu
Copy link
Contributor

wvu commented Oct 5, 2015

Lol, @OJ. I will take this, yeh? Will handle when I get home.

@OJ OJ merged commit 2769d66 into rapid7:master Oct 5, 2015
OJ added a commit that referenced this pull request Oct 5, 2015
@OJ
Copy link
Contributor

OJ commented Oct 5, 2015

Sorted @wvu-r7 :)

@OJ
Copy link
Contributor

OJ commented Oct 5, 2015

Also tested with Window payloads with and without the _uuid support in the stager.

@wvu wvu assigned OJ and unassigned wvu Oct 5, 2015
@wvu
Copy link
Contributor

wvu commented Oct 5, 2015

:P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

payload/linux/x64/shell/reverse_tcp broken
3 participants