Nessus plugin - add search to relevant commands

[sempervictus]

Utilize the SearchTerm param in Rex' Tables to filter scrolling
outputs.
Clean up argument parsing (implement one of the MSF standards).
Update help commands to reflect changes

Testing: basic functional tests only so far

[void-in]

@sempervictus That is actually a great contribution. When I rewrote that plugin almost a year back, the Nessus API changed from XML to JSON and the focus was to make the plugin workable with the latest version. It is great you focused on an area which don't get the love of devs!

[sempervictus]

Thanks, i try to please, figured you'd see this rather quickly (lurker).
You beat me to publishing the plugin by a short time, i actually wrote a whole API gem just for that ;).
#1621 was basically the same thing as this PR a few years ago.
For historical reference, getting the 'SearchTerm' bit adopted upstream took some work, and nobody really uses it - it originally came as a "workable alternative" to efforts by Kernelsmith when we were still entertaining dreams of bash-like pipes and such in console.
I use Nessus quite a bit, figured since i was doing some work on my PSH code (or rather bug-hunting framework module instantiation ghosts), i'd push another useful bit upstream.

[void-in]

This was wrong before and it is wrong here as well. The command is nessus_server_properties but the example is nessus_server_feed. We need to change either the command or the example description.

[sempervictus]

Addressed, thank you.

[jlee-r7]

Body is empty, delete this line.

[sempervictus]

I think the original author placed that there for formatting. Void-in: can
I nix the formatting line(s)?
On Feb 3, 2016 11:22 AM, "James Lee" notifications@github.com wrote:

In plugins/nessus.rb
#6517 (comment)
:

@@ -410,13 +479,19 @@ def cmd_nessus_server_status(*args)
end

   def cmd_nessus_admin(*args)

•    while (arg = args.shift)
  

•      case arg
  

•      when '-h', '--help'
  

•        print_status("nessus_admin")
  

•        print_status("Example:> nessus_admin")
  

•        print_status()
  

•        print_status("Checks to see if the current user is an admin")
  

•        print_status("Use nessus_user_list to list all users")
  

•        return
  

•      end
  

•    end
   if args[0] == "-h"
  

Body is empty, delete this line.

—
Reply to this email directly or view it on GitHub
https://github.com/rapid7/metasploit-framework/pull/6517/files#r51744471
.

[void-in]

@sempervictus Yes. It should be removed.

[jlee-r7]

@sempervictus Ah, I see where the confusion was now. That's not what I meant. The if block on that line has no body so it is a pointless comparison.

[jlee-r7]

Sorry I wasn't more clear

[void-in]

@jlee-r7 Yeah. I can see a confusion now but I think the latest commit shouldn't be reverted. The call to print_status() was included just for an empty line which isn't needed. Only thing left is to remove https://github.com/sempervictus/metasploit-framework/blob/ae38403bc29ec20c32f2cefeea8d3bd6f2990c4e/plugins/nessus.rb#L490-L492

[wvu]

@void-in: Are you taking this?

[void-in]

@wvu-r7 Please land this. I am away from my dev machine and will take another 10+ hours to get there. Sorry I didn't know it was assigned to me.

[sempervictus]

Thx guys. I've been using this a ton and its turned out extremely helpful
when trolling thru large reports in console. Actually easier than the GUI
or my pitiful api gem.
On Mar 2, 2016 12:41 PM, "Waqas Ali" notifications@github.com wrote:

@wvu-r7 https://github.com/wvu-r7 Please land this. I am away from my
dev machine and will take another 10+ hours to get there. Sorry I didn't
know it was assigned to me.

—
Reply to this email directly or view it on GitHub
#6517 (comment)
.

[void-in]

Thanks @wvu-r7 for landing. Great job @sempervictus