Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move android_stock_browser_iframe_dos_cve_2012_6301 and make it passive #6704

Merged
merged 1 commit into from Mar 23, 2016

Conversation

wchen-r7
Copy link
Contributor

What This PR Does

This PR actually addresses two things:

  1. It moves the module. dos/http is for http servers, not browsers.
  2. It should be passive, but the PassiveActions syntax is wrong, so it's not being treated as passive.

Verification

  • Start msfconsole
  • Do: use auxiliary/dos/http/android_stock_browser_iframe_dos_cve_2012_6301
  • You should see a deprecation message
  • Do: use auxiliary/dos/android/android_stock_browser_iframe
  • The auxiliary/dos/android/android_stock_browser_iframe module should be loaded
  • In the msf prompt, go to irb
  • In irb, do: framework.modules.create('auxiliary/dos/android/android_stock_browser_iframe').passive?
  • It should return true

This addresses two things:

1. The module is in the wrong directory. dos/http is for http
   servers, not browsers.
2. PassiveActions should not be a 2D array.
@wchen-r7 wchen-r7 changed the title Move android_stock_browser_iframe_dos_cve_2012_6301.rb Move android_stock_browser_iframe_dos_cve_2012_6301 and make it passive Mar 23, 2016
@lsato-r7 lsato-r7 self-assigned this Mar 23, 2016
@lsato-r7
Copy link
Contributor

hey @wchen-r7 the deprecation message formatting is off because of the long path/name

@lsato-r7 lsato-r7 merged commit 8c5c008 into rapid7:master Mar 23, 2016
lsato-r7 added a commit that referenced this pull request Mar 23, 2016
@wchen-r7 wchen-r7 deleted the cve_2012_6301_update branch August 22, 2016 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants