Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove overwritten keys from hashes #6789

Merged
merged 1 commit into from Apr 20, 2016
Merged

Conversation

bcook-r7
Copy link
Contributor

@bcook-r7 bcook-r7 commented Apr 20, 2016

This fixes #6772. I chose to delete the overwritten hash values, rather than merge, since it was clear that the overwritten values were never tested (since they had no effect.)

Verification

  • Visual code inspection (the fixes are fairly obvious)
  • On an up-to-date Kali-rolling VM, verify that msfconsole does not throw warnings with the system ruby when running a fresh metasploit-framework checkout with this PR, OR....
  • You can also simulate Kali's environment with RVM by updating to ruby 2.3.0 by modifying .ruby-version, reentering the directory, following rvm's instructions, then bundling the gems again.

@wchen-r7 wchen-r7 self-assigned this Apr 20, 2016
@wchen-r7 wchen-r7 merged commit 57cb8e4 into rapid7:master Apr 20, 2016
wchen-r7 added a commit that referenced this pull request Apr 20, 2016
@bcook-r7 bcook-r7 deleted the fix-6772 branch May 25, 2016 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 warnings about duplicated and overwritten keys
3 participants