Fix modules broken by @wchen-r7 's 4275a65407389f2d04d4cf72e788d826ee… #7069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These modules call check() in the exploit() function and expected to get a CheckCode::Vulnerable, now that check() returns Appears instead of Vulnerable they always refuse to run. I've flipped the logic, based on examples in other modules, now they refuse to run only if check() positively returns Safe.
|
Updated description to point to the apparent source PR. |
Release NotesFix check conditions that are impossible to meet in certain local exploits - In #5917, multiple local exploit checks were updated to meet the development guidelines. While doing that, some of the local exploits were modified to check codes that weren't actually used, causing the modules to never actually fire. This patch makes it possible to use the modules again if exploitable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix modules broken by @wchen-r7's 4275a65 commit (PR #5917).
I think that's the best way to do it, let me know (especially @wchen-r7) if it should be done differently.