Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed dir names according to CVE for new java exploit #734

Merged
merged 1 commit into from Aug 28, 2012
Merged

changed dir names according to CVE for new java exploit #734

merged 1 commit into from Aug 28, 2012

Conversation

jvazquez-r7
Copy link
Contributor

No description provided.

@todb-r7
Copy link

todb-r7 commented Aug 28, 2012

Picking up an OSVDB number before committing to Metasploit would obviate this step, since things wouldn't have to be moved around afterwards. That would make installer and update packaging easier -- it's a small hassle to deal with removed and renamed files for the installers and updates (they are special-cased).

@todb-r7
Copy link

todb-r7 commented Aug 28, 2012

Ah, and it makes merging more complicated than it needs to be as well, apparently:

mazikeen:./metasploit-framework$ git merge master
Auto-merging modules/exploits/multi/browser/java_jre17_exec.rb
CONFLICT (add/add): Merge conflict in modules/exploits/multi/browser/java_jre17_exec.rb
Automatic merge failed; fix conflicts and then commit the result.

Nothing really to be done about it at this point, but it would be nice to avoid this in the future.

@todb-r7 todb-r7 merged commit 363c091 into rapid7:master Aug 28, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants