remove unneeded badchars from payload specification for manageengine_connectionid_write, remove payload debug messages #7493
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #7487 in two ways. Looking at the manageengine_connectionid_write exploit, it did not need to specify badchars, because it encodes its payload as a safe hex string internally anyway. So, removing the specification makes this work again.
But, obviously not every exploit can lift this constraint; we need more. Looks like DEBUG mode got left enabled with rapid7/metasploit-payloads@0cbb86c . It is possible we have a bug in the debug output code, and it turns out that independently disabling this again also fixes the issue.
Verification
List the steps needed to make sure this thing works