Remove the bug where downcase() is invoked on password which is optio… #7529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nal and can be empty.
wvu
added a commit
to wvu/metasploit-framework
that referenced
this pull request
Nov 3, 2016
Don't think it was ever needed, since the password is case-sensitive. Fixed a minor merge conflict where PASSWORD became HttpPassword.
Release NotesThis fix addresses a |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The simple fix the bug where the module exploits/multi/http/tomcat_mgr_deploy will call downcast() on the password user parameter, but this parameter is optional and can be empty, causing an error.
Verification
List the steps needed to make sure this thing works
Assume you have tomcat mgr installed on localhost:
msfconsoleuse exploits/multi/http/tomcat_mgr_deployset RHOST 127.0.0.1