Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nil bug in generic/custom and change opt order #7762

Merged
merged 1 commit into from Dec 28, 2016
Merged

Fix nil bug in generic/custom and change opt order #7762

merged 1 commit into from Dec 28, 2016

Conversation

wvu
Copy link
Contributor

@wvu wvu commented Dec 28, 2016 •
edited

  • set PAYLOAD generic/custom
  • See no nil bug when it does the thing
  • set PAYLOADFILE or PAYLOADSTR
  • See it do the thing from your chosen option
  • set PAYLOADFILE and PAYLOADSTR
  • See it do the thing from PAYLOADSTR

@wvu
Fix nil bug in generic/custom and change opt order
29d6cf4 
I think PAYLOADSTR should take precedence over PAYLOADFILE. Usually,
you'll use PAYLOADFILE but might want to override with PAYLOADSTR. I
doubt this change will hurt anyone, since few people set both at once.
The payload description even says "either," so there's that.
@wvu wvu self-assigned this Dec 28, 2016
@wvu wvu merged commit 29d6cf4 into rapid7:master Dec 28, 2016
wvu added a commit that referenced this pull request Dec 28, 2016
@wvu
Land #7762, nil fix for generic/custom
524402a
@wvu wvu deleted the beug/nil branch December 28, 2016 11:52
@wvu
Copy link
Contributor Author

wvu commented Dec 28, 2016 •
edited by egypt

Release Notes

This fix addresses a nil dereference bug in the generic/custom payload if neither PAYLOADFILE nor PAYLOADSTR were specified.

@tdoan-r7 tdoan-r7 added the rn-fix release notes fix label Jan 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@wvu wvu

Labels
bug module payload rn-fix release notes fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wvu @tdoan-r7