fix migrate by process name #8110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wvu
reviewed
Mar 14, 2017
| @@ -42,7 +42,7 @@ def run | |||
| if datastore['SPAWN'] | |||
| print_status("Spawning notepad.exe process to migrate to") | |||
| target_pid = create_temp_proc | |||
| elsif datastore['PID'] != 0 | |||
There was a problem hiding this comment.
Aha! That does make sense, I should've noticed that and mentioned it in #8109. Thanks!
wvu
reviewed
Mar 15, 2017
| @@ -23,8 +23,8 @@ def initialize(info={}) | |||
| register_options( | |||
| [ | |||
| OptBool.new( 'SPAWN',[ false,'Spawn process to migrate to. If name for process not given notepad.exe is used.', true]), | |||
| OptInt.new( 'PID', [false, 'PID of process to migrate to.']), | |||
| OptString.new( 'NAME', [false, 'Name of process to migrate to.']), | |||
| OptInt.new( 'PID', [false, 'PID of process to migrate to.', nil]), | |||
There was a problem hiding this comment.
These should be nil by default if none specified.
Release NotesThis fix resolves an issue that prevented process migration through a specified process name from being handled as expected on Windows systems. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8109
This fixes the ability to migrate into a process by name (e.g., explorer.exe). The if/else block would never reach the NAME check because
pid != 0is always true (unless for some reason you specifically set it to 0).