Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing ranks #8169

Merged
merged 2 commits into from Apr 3, 2017
Merged

Add missing ranks #8169

merged 2 commits into from Apr 3, 2017

Conversation

farkwun
Copy link
Contributor

@farkwun farkwun commented Mar 31, 2017

This PR hopes to resolve some of the missing exploit module rankings as per #7923

I've also included a few lines of justification for each ranking - tell me if I'm off the mark!

../exec_shellcode.rb
Rank = Great
This exploit is missing autodetection and version checks,
but should be ranked Great due to high number of possible targets

../cfme_manageiq_evm_upload_exec.rb
Rank = Great
This exploit implements a check to assess target availability,
and the vulnerability does not require any user action

../dlink_dcs_930l_authenticated_remote_command_execution
Rank = Excellent
Exploit utilizes command injection

../efw_chpasswd_exec
Rank = Excellent
Exploit utilizes command injection

../foreman_openstack_satellite_code_exec
Rank = Excellent
Exploit utilizes code injection

../nginx_chunked_size
Rank = Great
Exploit has explicit targets with nginx version auto-detection

../tp_link_sc2020n_authenticated_telnet_injection
Rank = Excellent
See dlink_dcs_930l_authenticated_remote_command_execution,
exploit uses OS Command Injection

../hp_smhstart
Rank = Average
Must be specific user to exploit, no autodetection,
specific versions only

Verification

  • Run msftidy on the exploit modules, verify the below files no longer throw [INFO] No Rank Specified messages:
    • ../exploits/firefox/local/exec_shellcode.rb
    • ../exploits/linux/http/cfme_manageiq_evm_upload_exec.rb
    • ../exploits/linux/http/dlink_dcs_930l_authenticated_remote_command_execution.rb
    • ../exploits/linux/http/efw_chpasswd_exec.rb
    • ../exploits/linux/http/foreman_openstack_satellite_code_exec.rb
    • ../exploits/linux/http/nginx_chunked_size.rb
    • ../exploits/linux/http/tp_link_sc2020n_authenticated_telnet_injection.rb
    • ../exploits/linux/local/hp_smhstart.rb

../exec_shellcode.rb
Rank = Great
This exploit is missing autodetection and version checks,
but should be ranked Great due to high number of possible targets

../cfme_manageiq_evm_upload_exec.rb
Rank = Great
This exploit implements a check to assess target availability,
and the vulnerability does not require any user action

../dlink_dcs_930l_authenticated_remote_command_execution
Rank = Excellent
Exploit utilizes command injection

../efw_chpasswd_exec
Rank = Excellent
Exploit utilizes command injection

../foreman_openstack_satellite_code_exec
Rank = Excellent
Exploit utilizes code injection

../nginx_chunked_size
Rank = Great
Exploit has explicit targets with nginx version auto-detection

../tp_link_sc2020n_authenticated_telnet_injection
Rank = Excellent
See dlink_dcs_930l_authenticated_remote_command_execution,
exploit uses OS Command Injection

../hp_smhstart
Rank = Average
Must be specific user to exploit, no autodetection,
specific versions only
@h00die
Copy link
Contributor

h00die commented Apr 1, 2017

@h00die
Copy link
Contributor

h00die commented Apr 1, 2017

a lot of those are command execution modules and correct with the excellent ranking.

I think exec_shellcode and cfme_manageiq_evm_upload_exec should be excellent as well since its just code exec

I think hp_smhstart i think can be normal.

../exec_shellcode.rb
Rank Great -> Excellent

../cfme_manageiq_evm_upload_exec.rb
Rank Great -> Excellent

../hp_smhstart.rb
Rank Average -> Normal
@farkwun
Copy link
Contributor Author

farkwun commented Apr 2, 2017

Hi h00die!

I've made the changes to the files - verification remains the same :)

Please tell me if there's anything else preventing a merge!

@h00die h00die self-assigned this Apr 3, 2017
@h00die h00die merged commit 151ed16 into rapid7:master Apr 3, 2017
h00die added a commit that referenced this pull request Apr 3, 2017
@h00die
Copy link
Contributor

h00die commented Apr 3, 2017

Release Notes

Exploit rankings have been added for 8 modules.

@h00die
Copy link
Contributor

h00die commented Apr 3, 2017

@farkwun thanks for the submission, and all the explanations you added!

@tdoan-r7 tdoan-r7 added the rn-fix release notes fix label Apr 5, 2017
@farkwun farkwun deleted the add_missing_ranks branch April 6, 2017 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants