Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove special case check for invalid options #8470

Merged
merged 1 commit into from
May 30, 2017

Conversation

busterb
Copy link
Member

@busterb busterb commented May 27, 2017

When validating the result of a remote check method, we have invalid code to print the peer info when a datastore parameter fails validation. At that point, we might as well just follow the normal Exception handler path instead of special-casing it.

Verification

List the steps needed to make sure this thing works

  • Start msfconsole
  • use exploit/windows/smb/ms08_067_netapi
  • type check
  • Verify that an exception like this appears:
[-] Check failed: Msf::OptionValidateError The following options failed to validate: RHOST.

@bcoles
Copy link
Contributor

bcoles commented May 27, 2017

Works as intended.

🔨🐢

@busterb busterb self-assigned this May 27, 2017
@busterb
Copy link
Member Author

busterb commented May 27, 2017

Thanks @bcoles (and for pointing this bug out)

@busterb busterb merged commit b7620e1 into rapid7:master May 30, 2017
busterb pushed a commit that referenced this pull request May 30, 2017
@busterb
Copy link
Member Author

busterb commented May 30, 2017

Release Notes

This fix removes an invalid message when a user incorrectly specifies or omits certain module options.

@alrosenthal-r7 alrosenthal-r7 added the rn-fix release notes fix label May 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug library rn-fix release notes fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants