Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make smb_login scanner proxy-aware again #9058

Merged
merged 1 commit into from Oct 12, 2017

Conversation

hph86
Copy link
Contributor

@hph86 hph86 commented Oct 9, 2017

This PR makes the smb_login scanner module obey proxy settings. It fixes issue #9057. The following steps should trigger either a connection originating from the local system (without PR, unexpected) or a connection originating from the remote system (with PR, expected):

$ ssh -D 5555 jumphost
[switch window]
$ ./msfconsole
[...]
msf > use auxiliary/scanner/smb/smb_login
msf auxiliary(smb_login) > setg Proxies socks4:127.0.0.1:5555
Proxies => socks4:127.0.0.1:5555
msf auxiliary(smb_login) > set smbpass foobar
smbpass => foobar
msf auxiliary(smb_login) > set smbuser administrator
smbuser => administrator
msf auxiliary(smb_login) > set rhosts 10.0.0.233
rhosts => 10.0.0.233
msf auxiliary(smb_login) > run

@acammack-r7 acammack-r7 self-assigned this Oct 10, 2017
@acammack-r7 acammack-r7 merged commit 15adb82 into rapid7:master Oct 12, 2017
acammack-r7 added a commit that referenced this pull request Oct 12, 2017
@acammack-r7
Copy link
Contributor

Nice catch, thanks for the fix!

@acammack-r7
Copy link
Contributor

acammack-r7 commented Oct 12, 2017

Release Notes

The smb_login module will now respect the PROXIES datastore option again.

@vipzen
Copy link
Contributor

vipzen commented Oct 13, 2017

I was waiting for this. Thanks.

@hph86
Copy link
Contributor Author

hph86 commented Oct 14, 2017

Thanks for your quick action! 👍

@hph86 hph86 deleted the fix_smb_login_proxy branch October 14, 2017 17:39
@tdoan-r7 tdoan-r7 added the rn-fix release notes fix label Nov 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn-fix release notes fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants