-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Module cache improvements #9220
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neat, thank you. Looks sane at first pass, will try to get this merged ob my end and test it out.
lib/msf/core/module/full_name.rb
Outdated
@@ -21,7 +21,7 @@ module ClassMethods | |||
# | |||
|
|||
def fullname | |||
type + '/' + refname | |||
type + '/' + (refname.nil? ? '' : refname) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"#{type}/#{refname}" maybe?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you
lib/msf/core/module_manager/cache.rb
Outdated
@@ -98,7 +99,7 @@ def load_cached_module(type, reference_name) | |||
end | |||
|
|||
# @overload refresh_cache_from_module_files | |||
# Rebuilds database and in-memory cache for all modules. | |||
# Rebuilds module metadat store and in-memory cache for all modules. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
metadata
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you
The specs failing in ruby 2.3 look like they are things that should either be updated or removed.
|
My last commit has a one line that shouldn't have caused the tests to be failing. How do I kick off the tests again (without recommit)? |
Click 'Details' on the Travis CI build failed link above. Make sure you login to Travis CI with your github credentials first, you'll have a 'Restart build' button available then. |
I restarted test again, I expect may still fail. For me the tests fail on 2.3.5 but not on 2.4.2 and I ran locally on Linux to validate. |
I would suggest adding 'db/modules_metadata_base.pstore' to |
I kicked off the builds this morning and they are all passing now :/ |
@chlee: "I kicked off the builds this morning and they are all passing now :/" That makes me sad, I validated externally for the failed tests, wonder why it would start passing in travis now :-( Now looks like it is having a failure in 2.4.2, I suspect this is timing related, some tests are expecting caching to complete before run. We need to get consistent results before we land this. |
@jmartin-r7 - I think I see the problem - despise timing tests |
Landed, as the first Metasploit 5 PR. Thanks @clee-r7! |
Added 86c927e to fix a problem with msfvenom running. |
Release NotesThe module search system has been overhauled to require less memory, return results faster, and to not require a database to work at full speed. New module metadata and search options are also included in this back-ported feature from Metasploit 5. |
As part of the new data service changes (aka: Goliath) clean up of the current module caching was needed to allow an easier port to a data services model.
Changes:
Side effects:
When running without a DB:
When running with a DB