Fix pivot handler to not consume all packets #9492
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packet handlers should only return true if they consume a packet. Otherwise, they should return false so something else can consume it. This fixes port forwards by allowing the socket handler to see packets
that were otherwise being discarded in the pivot handler.
Fixes #9479
Verification
List the steps needed to make sure this thing works
msfconsole
./msfconsole -qx 'use multi/handler; set payload linux/x86/meterpreter_reverse_tcp; set lhost 192.168.56.1; run'
portfwd add -R -L 127.0.0.1 -l 8080 -p 8081
nc -lk 8080
nc 127.0.0.1 8081
Alternately, do anything that uses pivot functionality.