Update for MySQL 5.7 and above #9525
Merged
Conversation
Starting from MySQL 5.7 the password column was changed to authentication_string. I've added a check to determine the version. Tested on both MySQL 5.6 and 5.7.
|
@OsandaMalith you'll want to check the result of the automated checks above and resolve them. To test locally, run |
busterb
added a commit
that referenced
this pull request
Feb 8, 2018
|
See 1bb5499, I went ahead and fixed some of the minor style issues in the module and made the linter happy. Thanks a lot for the update @OsandaMalith ! |
jmartin-r7
added a commit
to jmartin-r7/metasploit-framework
that referenced
this pull request
Feb 12, 2018
|
@busterb can you please add release notes to the PR? |
Release NotesThis fix resolves an issue caused by renaming the 'password' column as 'authentication_string' in MySQL version 5.7 and onwards. The auxiliary/scanner/mysql/mysql_hashdump module now checks the MySQL version and uses the appropriate name for the column. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Starting from MySQL 5.7 the 'password' column was changed to 'authentication_string'. I've added a check to determine the version. If the version is higher than 5.6 the column 'authentication_string' will be used instead of 'password'. Tested on both MySQL 5.6 and 5.7.
The bug due to non existence of 'password' column in MySQL 5.7: