Support for Ruby 2.5.0 fixing OpenSSL warning #9576

[denisse-dev]

This change removes the SSL warning with Ruby 2.5.0 that was referenced from issue #9576

Warning:
/opt/metasploit/lib/msf/core/opt.rb:55: warning: constant OpenSSL::SSL::SSLContext::METHODS is deprecated

Replaced:
OpenSSL::SSL::SSLContext::METHODS

With
[:TLSv1_2, :TLSv1_1, :TLSv1, :SSLv3, :SSLv23, :SSLv2]

[sempervictus]

Umm, is that a good idea? I doubt the binary openssl implementation is looking to do v2. Is this call used anywhere to determine the capabilities of the local lib, or just to enumerate these values?

[jmartin-tech]

I agree with @sempervictus, it would be nice to pull a more dynamic list from the gem as the old method did. Maybe there is some way we can generate this list still.

Looking at the latest 2.5.0 openssl gem this constant is now provided from an private_constant:

METHODS_MAP.flat_map { |name,|
        [name, :"#{name}_client", :"#{name}_server"]
      }.freeze

[jmartin-tech]

It is required that code in your fork be merged from a unique branch in your repository to master in Rapid7's. Please create a new branch in your fork of framework and resubmit this from that branch.

git checkout -b <BRANCH_NAME>
git push <your_fork_remote> <BRANCH_NAME>

This helps protect the process, ensure users are aware of commits on the branch being considered for merge, allows for a location for more commits to be offered without mingling with other contributor changes and allows contributors to make progress while a PR is still being reviews.

Closing based on the this requirement, please do resubmit from a unique branch.

[maxrep66]

de-edra how can i chage it and whre ?? how can i do what u say can u explain to me a little better pls

thx very much

[busterb]

Hi, I'm going to fix this up, since we do need this PR in the tree.

[busterb]

I'm adding support for Ruby 2.5 first by adding underlying helper methods to rex-socket:
rapid7/rex-socket#11

[busterb]

Thanks @da-edra , I improved your change in a new PR here: #9762

[maxrep66]

thx bro i fix metasploit problem now i have another problem i cant fix and is driving me crazy install ahmyth i do all but not build i dont know why u can help me??'

…

On Thu, Mar 29, 2018 at 3:31 PM, maxrep733 yo ***@***.***> wrote: On Mon, Mar 26, 2018 at 10:48 AM, Brent Cook ***@***.***> wrote: > Closed #9598 <#9598>. > > — > You are receiving this because you commented. > Reply to this email directly, view it on GitHub > <#9598 (comment)>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/Ajr5fQHXSNPErNpRHzzAOznvRFXCInR1ks5tiKtvgaJpZM4SOJdI> > . >

[busterb]

Please don't post off-topic comments on closed tickets.

[maxrep66]

ok no problem but u know how can i fix ahmyth problem???

…

On Thu, Mar 29, 2018 at 5:16 PM, Brent Cook ***@***.***> wrote: Please don't post off-topic comments on closed tickets. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#9598 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/Ajr5fU9giPNaYv7eF_sWiwVShTDg-v-Yks5tjPrPgaJpZM4SOJdI> .