Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WDS update to add deploymentshare$ and customsettings.ini #9637

Closed
wants to merge 3 commits into from

Conversation

NinjaStyle82
Copy link

On MDT there is an additional share which may be useful to search for credentials. deploymentshare$ is created when you create a deployment share in MDT. It is possible to add a machine to the domain after imaging using customsettings.ini. This adds both the addition of deploymentshare$, and the search and ini parsing needed to pull credentials from customsettings.ini.

@jmartin-tech
Copy link
Contributor

Jenkins test this please.

@acammack-r7 acammack-r7 added the attic Older submissions that we still want to work on again label Dec 5, 2018
@acammack-r7
Copy link
Contributor

Hello @NinjaStyle82, I'm sorry that your first contribution has been left sitting for so long! This change looks reasonable, but a long time has passed since we first added the module and I don't think we have WDS setup still available to us. If you have a packet capture and screenshots of the output available for us to review that would definitely help things along. You can email them to msfdev AT metasploit.com if you want (be sure to reference this PR!). In the mean time, to help us understand how many PRs are being actively developed, I am going to close this for now and add the attic label so we don't lose track of it. You can learn about our new PR label on our wiki. Feel free to reopen once we have more testing information.

Another thing that could help this move forward would be adding module documentation for this module, since it seems like you understand this module better than anyone on the team currently does. It is completely optional, but would help us out a lot. You can find out more about the process here and PR 10828 is a good example of well-written module documentation. Again, you don't have to write it to get this landed, but it will help us evaluate this PR better. Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
attic Older submissions that we still want to work on again module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants