Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

if multi/handler is disabled, exit #9639

Merged
merged 1 commit into from
Mar 1, 2018
Merged

if multi/handler is disabled, exit #9639

merged 1 commit into from
Mar 1, 2018

Conversation

busterb
Copy link
Member

@busterb busterb commented Feb 27, 2018 •
edited by wvu
Loading

This prevents mult/handler from sitting catatonic if it has been told to actually do nothing at all. This just burned me again, and I know @acompton-r7 has run into this as well.

Verification

  • Start msfconsole
  • use multi/handler
  • set DisablePayloadHandler true
  • Verify that if you run the module, it exits like follows instead of hanging:
payload => php/meterpreter/reverse_tcp
lhost => 127.0.0.1
[-] DisablePayloadHandler is enabled, so there is nothing to do. Exiting!

@jmartin-tech
Copy link
Contributor

Jenkins test this please.

@wvu wvu self-assigned this Mar 1, 2018
wvu added a commit to wvu/metasploit-framework that referenced this pull request Mar 1, 2018
@wvu
Land rapid7#9639, multi/handler exit on disabled handler
d843750 
If DisablePayloadHandler is set, abort instead of hanging.
@wvu wvu merged commit 325ad72 into rapid7:master Mar 1, 2018
@wvu
Copy link
Contributor

wvu commented Mar 1, 2018

Solid change. Thanks!

@wvu
Copy link
Contributor

wvu commented Mar 1, 2018 •
edited by tdoan-r7
Loading

Release Notes

This fix resolves an issue that caused multi/handler to hang when DisablePayloadHandler is enabled. Now, it aborts when the DisablePayloadHandler is enabled.

@h00die
Copy link
Contributor

h00die commented Mar 1, 2018

OMG!!!!! I ran into this a few months back and it drove me crazy, just got lost in my notes for other modules.
Good PR +1 from me!

msjenkins-r7 pushed a commit that referenced this pull request Mar 1, 2018
@wvu @msjenkins-r7
Land #9639, multi/handler exit on disabled handler
3fd2862 
If DisablePayloadHandler is set, abort instead of hanging.
@tdoan-r7 tdoan-r7 added the rn-fix release notes fix label Mar 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@wvu wvu

Labels
bug module rn-fix release notes fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@busterb @jmartin-tech @wvu @h00die @tdoan-r7