Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docker build #9672

Merged
merged 1 commit into from Mar 6, 2018
Merged

Fix docker build #9672

merged 1 commit into from Mar 6, 2018

Conversation

dcylabs
Copy link
Contributor

@dcylabs dcylabs commented Mar 6, 2018

Fix docker build

Observation

docker run -ti --rm --network=host metasploitframework/metasploit-framework

results in :

docker: Error response from daemon: OCI runtime create failed: container_linux.go:296: starting container process caused "exec: \"docker/entrypoint.sh\": stat docker/entrypoint.sh: no such file or directory": unknown.

This is due to the .dockerignore file that ignore the docker directory except the msfconsole.rc(forgetting to except entrypoint.sh)

Verification

  • Start docker build -t msf .
  • Start docker run -ti --rm --network=host msf
  • Verify that msfconsole is starting and behaving as expected

@firefart
Copy link
Contributor

firefart commented Mar 6, 2018

Oh thanks for the spot! Didn't notice it in the dev build :)

@busterb busterb added the bug label Mar 6, 2018
@firefart firefart merged commit 36eb8ce into rapid7:master Mar 6, 2018
firefart added a commit that referenced this pull request Mar 6, 2018
@firefart
Copy link
Contributor

firefart commented Mar 6, 2018

Release Notes

This fix addresses a missing file in the docker image.

@firefart firefart self-assigned this Mar 6, 2018
msjenkins-r7 pushed a commit that referenced this pull request Mar 7, 2018
@tdoan-r7 tdoan-r7 added the rn-fix release notes fix label Mar 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug rn-fix release notes fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants