Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation on modules/auxiliary/scanner/db2/discovery #9933

Merged
merged 3 commits into from
Jun 27, 2018

Conversation

gcleite
Copy link
Contributor

@gcleite gcleite commented Apr 26, 2018

Part of #8296
adds documentation on modules/auxiliary/scanner/db2/discovery

@gcleite gcleite mentioned this pull request Apr 26, 2018
@bcoles bcoles added the docs label Apr 26, 2018
@h00die h00die self-assigned this Apr 26, 2018

## Verification Steps

To test this module, you must make sure there is at least one reacheable DB2 Discovery Service at the target address range or CIDR identifier.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this line can be removed


## Scenarios

```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any additional info on this server, like version or host OS? While those may not make a difference on this module, we've been adding that for consistency. Something like
### DB2 version a.b.c.d on Ubuntu 16.04

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This module currently returns only the node name and product id. I'll check if I can make an PR on the module to include more info on the server.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've checked the module implementation and it looks like we cannot get more info on the server only by the db2 discovery service

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, however I assume you own the device being scanned and would therefore have some insight into what version and OS it's being run as.
While it may not be displayed by the module, think of it like this. In 2 years when this module stops working, we'll look back at the tickets and docs and be able to say "we know there was good output when running on foo operating system and baz db2 version. Lets go back to that and then confirm it still good, and that it was db2 changing how it works, and not some downstream effect of another framework change."
It's not required, but I think it makes a nice difference.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, sorry for the misunderstanding. Just added a few more details on the target.

- Added information on the server and Database versions
- Example on product id output
@wvu
Copy link
Contributor

wvu commented Jun 27, 2018

Stealing this from you because it's an easy merge, @h00die. <3

Copy link
Contributor

@wvu wvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes implemented.

@wvu wvu self-assigned this Jun 27, 2018
wvu added a commit to wvu/metasploit-framework that referenced this pull request Jun 27, 2018
@wvu wvu merged commit 0e6e4bc into rapid7:master Jun 27, 2018
@wvu
Copy link
Contributor

wvu commented Jun 27, 2018

Release Notes

This adds documentation for the auxiliary/scanner/db2/discovery module.

@wvu
Copy link
Contributor

wvu commented Jun 27, 2018

Checkbox checked in #8296. Thanks!

@h00die
Copy link
Contributor

h00die commented Jun 27, 2018

No issues with that. I've had a lot of life changes (that I knew were coming), and thought they would have subsided by now, but alas not yet. I'll be back, but thanks for picking up my slack!

@gcleite gcleite deleted the docs/auxiliary-scanner-db2-discovery branch July 2, 2018 17:29
@tdoan-r7 tdoan-r7 added the rn-enhancement release notes enhancement label Jul 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs rn-enhancement release notes enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants