Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RSYNC module realm #43

Merged
merged 2 commits into from Dec 14, 2015
Merged

Conversation

jhart-r7
Copy link
Contributor

@jhart-r7 jhart-r7 commented Dec 8, 2015

I've followed CONTRIBUTING.md but even without this PR bundle exec rake spec fails for me so I cannot complete the testing required.

For rapid7/metasploit-framework#6266

@wvu
Copy link
Contributor

wvu commented Dec 9, 2015

Failing on master as well. Taking a look.

@jhart-r7
Copy link
Contributor Author

jhart-r7 commented Dec 9, 2015

Thanks @wvu-r7. All of the tests fail horribly for me without this PR locally, and with this PR applied travis seems to have all of those same problems and more.

@wvu
Copy link
Contributor

wvu commented Dec 9, 2015

We found the problem, and @sgonzalez-r7 is working on a fix. Related to rapid7/metasploit_data_models#140.

@wvu wvu self-assigned this Dec 9, 2015
@wvu
Copy link
Contributor

wvu commented Dec 10, 2015

Complete fix here: #44.

@wvu
Copy link
Contributor

wvu commented Dec 11, 2015

@jhart-r7: Would you mind rebasing or merging master? Whichever you prefer. I think you rebase PRs like some of us do.

@jhart-r7
Copy link
Contributor Author

Sure. Incoming.

@wvu wvu merged commit 1dcabe5 into rapid7:master Dec 14, 2015
wvu added a commit that referenced this pull request Dec 14, 2015
wvu added a commit that referenced this pull request Dec 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants