Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug/ms 850/shoulda matchers broken #44

Merged
merged 3 commits into from Dec 11, 2015
Merged

Bug/ms 850/shoulda matchers broken #44

merged 3 commits into from Dec 11, 2015

Conversation

sgonzalez-r7
Copy link
Contributor

MS-850

Verification Steps

  • rm Gemfile.lock
  • bundle install
  • rake spec
  • VERIFY specs passing

Post VerificationSteps

Version

  • Remove PRERELEASE and its comment from lib/metasploit/model/version.rb
  • note compatible change: Incremented PATCH.

Gem build

  • gem build *.gemspec
  • VERIFY the gem has no '.pre' version suffix.

RSpec

  • git commit -a
  • checkout master
  • merge bug/MS-850/shoulda-matchers-broken
  • rake spec
  • VERIFY specs passing

Commit & Push

  • git push origin master

Release (Complete the following on master)

  • rvm use ruby-2.1@metasploit-model
  • rm Gemfile.lock
  • bundle install
  • rake release

@sgonzalez-r7
Fix Shoulda matchers
37b5f9a 
MS-850

* update length validation method name
* add should matchers configuration to spec_helper
@sgonzalez-r7
Increment patch level
2d9b6e2 
MS-850
@wvu wvu self-assigned this Dec 9, 2015
@wvu wvu mentioned this pull request Dec 10, 2015
Merged
@wvu wvu removed their assignment Dec 10, 2015
@wvu
Copy link
Contributor

wvu commented Dec 10, 2015

Works for me. Unassigning myself so someone else can do the rake release.

@sgonzalez-r7
Remove JRuby build from Travis CI
77ebdbc 
MS-850

* due to failing bundle install for redcarpet
  and shoulda-matchers gems
@jhart-r7
Copy link
Contributor

@wvu-r7, is the issue that you can't rake release? From the looks of things, there are several folks who could help -- ping @jlee-r7 @shuckins-r7 @dmaloney-r7, etc.

@sgonzalez-r7
Copy link
Contributor Author

Hi Jon. Sorry for the delay. We’ll be releasing the fix this morning. SG

Sonny Gonzalez
sonny_gonzalez@rapid7.com
Rapid7, MetaSploit Pro
(512) 739-9268

From: Jon Hart
Reply-To: rapid7/metasploit-model
Date: Friday, December 11, 2015 at 10:16 AM
To: rapid7/metasploit-model
Cc: Sonny Gonzalez
Subject: Re: [metasploit-model] Bug/ms 850/shoulda matchers broken (#44)

@wvu-r7https://github.com/wvu-r7, is the issue that you can't rake release? From the looks of things, there are several folks who could help -- ping @jlee-r7https://github.com/jlee-r7 @shuckins-r7https://github.com/shuckins-r7 @dmaloney-r7https://github.com/dmaloney-r7, etc.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/44#issuecomment-163978519.

@dmohanty-r7 dmohanty-r7 merged commit 77ebdbc into master Dec 11, 2015
@wvu
Copy link
Contributor

wvu commented Dec 11, 2015

@jhart-r7: We got it, thanks. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sgonzalez-r7 @wvu @jhart-r7 @dmohanty-r7