Skip to content

Commit

Permalink
Adds nokogiri dependency.
Browse files Browse the repository at this point in the history
A library change is causing newer HTML reports to return HTML with
IE9-specific tags. REXML cannot parse these tags (are they valid XML?),
so in order to be able to return ad hoc HTML reports, this dependency is
being added.

If this dependency proves to be a smooth transition, we may wish to
convert our parsing code to using it.
  • Loading branch information
mdaines-r7 committed Jun 12, 2014
1 parent da5f1c4 commit dcb018f
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
1 change: 1 addition & 0 deletions lib/nexpose.rb
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@

require 'date'
require 'rexml/document'
require 'nokogiri'
require 'net/https'
require 'net/http'
require 'uri'
Expand Down
3 changes: 2 additions & 1 deletion nexpose.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

Gem::Specification.new do |s|
s.name = 'nexpose'
s.version = '0.7.6'
s.version = '0.8.0'
s.homepage = 'https://github.com/rapid7/nexpose-client'
s.summary = 'Ruby API for Rapid7 Nexpose'
s.description = 'This gem provides a Ruby API to the Nexpose vulnerability management product by Rapid7.'
Expand All @@ -17,4 +17,5 @@ Gem::Specification.new do |s|

s.add_runtime_dependency('librex', '~> 0.0', '>= 0.0.68')
s.add_runtime_dependency('rex', '~> 1.0', '>= 1.0.2')
s.add_runtime_dependency('nokogiri', '~> 1.6', '>= 1.6.2')

This comment has been minimized.

Copy link
@erran-r7

erran-r7 Jul 21, 2014

Contributor

@mdaines-r7 @gschneider-r7 @gravindran-r7 @kprzerwa-r7 Why is the dependency on such a specific version? Why not just use "~> 1.6" alone? On OS X machines 1.6.2/1.6.3 may fail to install. The latest version I've been able to install so far (debugging further now) was 1.6.1.

end

0 comments on commit dcb018f

Please sign in to comment.