Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added cpe for honewell devices #558

Closed
wants to merge 1 commit into from

Conversation

ycamper
Copy link

@ycamper ycamper commented Mar 21, 2023

Description

Adding CPE for honeywell label printers.

Motivation and Context

How Has This Been Tested?

Yes:

mark@bleep:~/recog$ echo "Honeywell PM43;P10.17.019667" | bin/recog_match xml/snmp_sysdescr.xml
MATCH: {"matched"=>"Honeywell Thermal Label Printer (Previously Intermec)", "hw.vendor"=>"Honeywell", "hw.model"=>"PM43", "hw.version"=>"10.17.019667", "hw.product"=>"Thermal Label Printer PM43", "hw.device"=>"Printer", "os.vendor"=>"Honeywell", "os.product"=>"Thermal Label Printer PM43", "os.device"=>"Printer", "os.cpe23"=>"cpe:/o:honeywell:intermec_PM43_firmware:10.17.019667", "service.protocol"=>"snmp", "fingerprint_db"=>"snmp.sys_description", "data"=>"Honeywell PM43;P10.17.019667"}

Types of changes

Checklist:

  • [* ] I have updated the documentation accordingly (or changes are not required).
  • [* ] I have added tests to cover my changes (or new tests are not required).
  • [* ] All new and existing tests passed.

@@ -3540,6 +3540,7 @@ Copyright (c) 1995-2005 by Cisco Systems
<param pos="0" name="os.vendor" value="Honeywell"/>
<param pos="0" name="os.product" value="Thermal Label Printer {hw.model}"/>
<param pos="0" name="os.device" value="Printer"/>
<param pos="0" name="os.cpe23" value="cpe:/o:honeywell:intermec_{hw.model}_firmware:{hw.version}"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I take it the CPE was added by hand instead of following the Updating CPEs instructions?

Error output from python update_cpes.py xml/snmp_sysdescr.xml official-cpe-dictionary_v2.3.xml cpe-remap.yaml:

...
xml/snmp_sysdescr.xml: ERROR: Product thermal_label_printer_{hw.model} from vendor honeywell invalid for CPE h and no mapping.
xml/snmp_sysdescr.xml: ERROR: Product thermal_label_printer_{hw.model} from vendor honeywell invalid for CPE o and no mapping.
...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, modifying the os.product value to create alignment with the CPE values won't help us today since update_cpes.py does not currently support interpolation in the emitted *. cpe23 values.

@mkienow-r7 mkienow-r7 closed this May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants