Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get domain names #153

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Get domain names #153

wants to merge 2 commits into from

Conversation

vs7997
Copy link

@vs7997 vs7997 commented Feb 22, 2021

…alSecurityAuthorityService.java to get a list of domain names for the corresponding SIDs.

Description

Added a function with name lookupDomainNamesForSIDs in src\main\java\com\rapid7\client\dcerpc\mslsad\LocalSecurityAuthorityService.java to get a list of domain names for the corresponding SIDs. This function is similar to the function which is used to get translated names for the corresponding SIDs.

Motivation and Context

Getting a username along with its domain name was required while working on a project. But the current library code do not offer this functionality. Extending the LocalSecurityAuthorityService.java and adding a function was a solution but it would be easier if smbj-rpc offered this functionality.

How Has This Been Tested?

This has been tested by using single as well as multiple SIDs as arguments. The response is as expected i.e. an array of domain names.

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist:

  • [check ] I have updated the documentation accordingly (or changes are not required).
  • [ check] I have added tests to cover my changes (or new tests are not required).
  • [ check] All new and existing tests passed.

Sadhu added 2 commits February 22, 2021 12:44
…alSecurityAuthorityService.java to get a list of domain names for the corresponding SIDs.
…alSecurityAuthorityService.java to get a list of domain names for the corresponding SIDs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant