Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fallback to using option code if its not an id #163

Conversation

indykoning
Copy link
Member

No description provided.

@royduin
Copy link
Member

royduin commented Oct 18, 2022

It should always be an ID right? If it's not there is something really wrong with your Magento installation and/or product import. This way it's ignored, is that the right thing to do? Or is it better to throw an exception?

@indykoning
Copy link
Member Author

If the options always have proper labels attached this shouldn't occur.
However if the labels are not properly given to the option, or the multiselect values were managed by code e.g. by an extension adding a custom attribute it is still possible to get a string in there instead of an id.

@royduin royduin merged commit 9984c29 into rapidez:master Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants