Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move config to files in Rapidez folder #356

Merged
merged 5 commits into from
Oct 13, 2023

Conversation

indykoning
Copy link
Member

This is a POC of moving the config to the Rapidez folder.
It works the same way as statamic does it, however for the base config there is still a config/rapidez.php

@royduin
Copy link
Member

royduin commented Oct 10, 2023

Maybe move config/rapidez.php to config/rapidez/system.php? But that will cause a lot of replaces... rapidez.store => rapidez.system.store. Maybe just include config/rapidez/system.php in config/rapidez.php? That way we can still use rapidez.store and we can edit everything from config/rapidez/*

@indykoning
Copy link
Member Author

Because Laravel builds the config based on the paths in the config folder once published we will need to copy this rapidez.php over to the /config folder as well in order to load the /config/rapidez/system.php

@royduin
Copy link
Member

royduin commented Oct 13, 2023

Just double checking; works with config caching?

@indykoning
Copy link
Member Author

Config caching (and optimize in general) seem to be working without issue

@indykoning indykoning marked this pull request as ready for review October 13, 2023 11:21
@royduin
Copy link
Member

royduin commented Oct 13, 2023

Nice, just some conflicts 😇 and we also need to check all modules: https://github.com/search?q=org%3Arapidez%20config(%27rapidez.&type=code

@indykoning
Copy link
Member Author

From the search, the only packages being incompatible seem to be the 2 with the PRs above this comment

@royduin royduin merged commit 9171204 into rapidez:master Oct 13, 2023
6 of 12 checks passed
@royduin
Copy link
Member

royduin commented Oct 13, 2023

Last thing to do is add a upgrade note?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants